search

koajs / examples

Example Koa apps
4.52k stars 744 forks source link

[Suggestion] Add coding style check #89

Closed bananaappletw closed 8 years ago

bananaappletw commented 8 years ago

Maybe adding coding styles check for this repo could make the example codes coherence. Just some suggestion. See also: https://github.com/koajs/koa/blob/v2.x/.eslintrc.yml https://github.com/feross/standard

bananaappletw commented 8 years ago

@hemanth What do you think about this? In general, most of rules could be accepted by js programmer. But there is still a fierce debate about semicolon. I don't have bias against these two different coding style. One is with semicolon, the other isn't. Although, it required better understanding about statements to write code without semicolon. But mostly, code with semicolon could avoid more errors than one without it. I think that's why koa is using one with semicolon.

hemanth commented 8 years ago

Makes absolute sense, please add them.

bananaappletw commented 8 years ago

Sure!!! But I have some homework to do this week. Maybe next week, I will have time to implement it. Thanks for the reply. 😄