koajs / examples

Example Koa apps
4.52k stars 744 forks source link

update examples to koa@2 #97

Closed DoumanAsh closed 7 years ago

DoumanAsh commented 7 years ago

While studying koajs capabilities i made some REST API by using latest koa. The question are examples, in this repo, should consist of next version yet or until official release only koa1?

About my code https://github.com/DoumanAsh/lazy-http-can This repo consist of simple REST service that allows you to test HTTP requests. There are several things:

bananaappletw commented 7 years ago

@DoumanAsh Hi, I just created koa2-example. I will try to migrate koa examples to koa2 in my available time.

haoxins commented 7 years ago

I'll update all examples to koa@2 next weekend :)

Also, PRs welcome! 😄

bananaappletw commented 7 years ago

@coderhaoxin Hi, I already migrate some examples. You could setup the initial process of migrating this repo to koa@2 (babel, eslint ......). Then I could send the pull request for the examples I migrated. Thanks for the enhancement of this repo.

bananaappletw commented 7 years ago

@coderhaoxin Or, you want to remain the this repo for koa1. I could transfer my current repo (already migrate some examples for koa2) to koa organization. And continue my migration work on koa organization. What do you think about it?

haoxins commented 7 years ago

I'd rather just create a branch such as koa-v1 for koa@v1 :)

@bananaappletw 👍 Feel free to submit PRs to master for your migration. ((>_<))

bananaappletw commented 7 years ago

@coderhaoxin Could you create koa-v1 branch in this repo? At least, we should backup koa@v1 examples before migrate master branch to koa2. Just copy current master to koa-v1. I don't have privilege to do that. Then, I send the pull request to master. Thanks.

haoxins commented 7 years ago

Could you create koa-v1 branch in this repo?

DONE :)

haoxins commented 7 years ago

50bcadf73e3f61278dbee08a7b10183f32a206c8