search

koajs / generic-session

koa session store with memory, redis or others.
MIT License
414 stars 65 forks source link

Refactor for koa 2 #122

Closed arch-mage closed 7 years ago

arch-mage commented 7 years ago

I convert the sources to use async/await syntax for koa 2. All test passed, the tests has been rewritten too of course to be compatible with koa 2.

But, I think there is a serious problem in ctx.session getter/setter. It has side effect when accessing ctx.session which can cause problem. Even though all tests pass, I think that getter/setter API should be changed.

arch-mage commented 7 years ago

Well, I forgot to change .travis.yml file :grimacing:. async/await needs node 7.6 or higher.

nsimmons commented 7 years ago

Can be closed now that #123 is merged.

niftylettuce commented 7 years ago

see v2.x