search

koajs / generic-session

koa session store with memory, redis or others.
MIT License
414 stars 65 forks source link

Refactor to koa 2 - Supports node 6.x and 7.x #123

Closed nsimmons closed 7 years ago

nsimmons commented 7 years ago

This PR is a combination of https://github.com/koajs/generic-session/pull/122 and https://github.com/koajs/generic-session/pull/81.

The code is written to use async / await to match Koa 2 middleware style, but uses babel to convert the syntax to be compatible with node 6.9.0+ being the official LTS version of node. I think it's important for this module to support v6 of node, and also be ready to use async / await syntax as soon as the next LTS version of node supports it.

This PR adds an additional step that make build must be run before publishing.

nsimmons commented 7 years ago

@dead-horse Could i get some 👀 on this?

niftylettuce commented 7 years ago

looks good here

nsimmons commented 7 years ago

Awesome. I'll rebase this PR ASAP so it can get merged.

nsimmons commented 7 years ago

This is ready to go. @niftylettuce you good to merge this and release?

nsimmons commented 7 years ago

Anyone able to merge this PR? CI says pending here but it's green if you click through.

niftylettuce commented 7 years ago

Nice work, let me test it later today and I'll accept/merge/publish

niftylettuce commented 7 years ago

@nsimmons OK taking a look now, sorry for delay!

nsimmons commented 7 years ago

Thanks for taking a look! Glad to see this will ship now. 👏

niftylettuce commented 7 years ago

@nsimmons should we also update badge for Node in Readme? And should we provide clearer docs for older version support? e.g. we now have new koa() and prior to that I don't think we did

nsimmons commented 7 years ago

mm yes i will take a look

dead-horse commented 7 years ago

@niftylettuce what's your npm name?

and you should update History.md before publish 2.0.0

niftylettuce commented 7 years ago

@dead-horse it's "niftylettuce" on NPM

dead-horse commented 7 years ago

added

niftylettuce commented 7 years ago

thanks @dead-horse - I went ahead and updated History.md and released new version to NPM at v2.0.0 cc @nsimmons - please ensure it works in production from NPM for you as well!

nsimmons commented 7 years ago

Will upgrade today and will open an issue if I find anything. Thanks!