search

koajs / generic-session

koa session store with memory, redis or others.
MIT License
414 stars 65 forks source link

fix: always refresh session #95

Closed dead-horse closed 8 years ago

dead-horse commented 8 years ago

closes #93 #94

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.1%) to 96.269% when pulling 5a90180c3b0b1377935db682066e1e9fa827e1bd on refresh-when-error into 3d4d8d626d8d0d36afaae5ef71b99b005044a294 on master.

niftylettuce commented 8 years ago

please merge and cut a new release

dead-horse commented 8 years ago

1.11.3

niftylettuce commented 8 years ago

thank you!!!!

niftylettuce commented 8 years ago

@dead-horse @fengmk2 can you please do an npm deprecate notice for people using prior versions? this is a big bug, especially for those that use flash messaging.

niftylettuce commented 8 years ago

@dead-horse @fengmk2 I still think this is broken. If you do a ctx.redirect right after setting a new setting property, such as ctx.session.foo = 'bar';, then the next time the session loads, ctx.session.foo is undefined and the session didn't save.