koajs / joi-router

Configurable, input and output validated routing for koa
MIT License
450 stars 96 forks source link

Remove is-gen-fn dependency #130

Open yelworc opened 3 years ago

yelworc commented 3 years ago

The is-gen-fn package causes a DeprecationWarning with Node 16:

 Uncaught DeprecationWarning: Invalid 'main' field in '/home/crowley/work/uniq/uniq-conferencier/node_modules/is-gen-fn/package.json' of 'yes'. Please either fix that or report it to the module author
  at tryPackage (node:internal/modules/cjs/loader:359:15)
  […]

Since it is fairly trivial, just include the generator function check here.

yelworc commented 3 years ago

Ah, I did glance at the open issues, but didn't look closely at the open PRs! Alright, feel free to close this, then (unless you maybe want to merge it as a temporary fix, since it could be released as a patch version until #128 lands).

Aldekein commented 3 years ago

The DeprecationWarning: Invalid 'main' field bugs me too. Its source is is-gen-fn@0.0.1 in dependencies of joi-router.

flofehrenbacher-sz commented 1 year ago

Any updates regarding this PR? Would also love to use it without the deprecation warning

3imed-jaberi commented 1 year ago

Updates: For now, you can use @koa-better-modules/joi-router which contains all the changes that must be in v9.x.x until I can publish the next official release under @koa/joi-router (expected in the coming few weeks).

Check 👀

hckhanh commented 1 year ago

Hi @3imed-jaberi, is there anything new for this PR, I created another PR for this: #137

jackykwan-eventx commented 1 year ago

@3imed-jaberi hello, is this package currently still under maintenence ? seems like no updates for a long period of time

3imed-jaberi commented 1 year ago

Hey Guys, next week we will publish the latest version (including the latest fixed) under @koa/joi-router. If you don't like to wait for next week, you can use the latest version by installing @koa-better-modules/joi-router

More details here