Support configuring shown properties

koajs / json-error

Error handler for pure-JSON apps

MIT License

91 stars 3 forks source link

Support configuring shown properties #6

Closed nfantone closed 8 years ago

nfantone commented 8 years ago

Allow clients to define which properties they want to omit or include in their json error responses.
Add unit tests for those scenarios.
Fix current tests that were not working on node 4+.
Enhance .gitignore file.
Upgrade all devDependencies.
Format code.

jonathanong commented 8 years ago

hi i just glanced over this. from all the noise, i'm not sure what's going on. make sure the tests pass and i'll review!

nfantone commented 8 years ago

The reason tests are failing is because Travis is running them on node v0.11.16. They are working fine on 0.12, 4 and 5.

Is it a requisite for this project to have tests run in older versions? If so, please add some kind of explicit comment or documentation about that, somewhere. Or you could use the "engine" attribute of package.json.

nfantone commented 8 years ago

@jonathanong Having said all that: would you want me to add a linter (based on whatever set of rules you point me to) and enhance docs for this project? I could do that if you like.

jonathanong commented 8 years ago

updated travis n stuff :) i don't mind adding other stuff like docs and linting, but they should be separate PRs or at least separate commits

nfantone commented 8 years ago

@jonathanong Roger that. Let me separate things a bit. I'll turn this into two PRs.