Closed nfantone closed 8 years ago
hi i just glanced over this. from all the noise, i'm not sure what's going on. make sure the tests pass and i'll review!
The reason tests are failing is because Travis is running them on node v0.11.16. They are working fine on 0.12, 4 and 5.
Is it a requisite for this project to have tests run in older versions? If so, please add some kind of explicit comment or documentation about that, somewhere. Or you could use the "engine"
attribute of package.json
.
@jonathanong Having said all that: would you want me to add a linter (based on whatever set of rules you point me to) and enhance docs for this project? I could do that if you like.
updated travis n stuff :) i don't mind adding other stuff like docs and linting, but they should be separate PRs or at least separate commits
@jonathanong Roger that. Let me separate things a bit. I'll turn this into two PRs.
.gitignore
file.devDependencies
.