search

koajs / koa-body

koa body parser middleware
MIT License
950 stars 130 forks source link

typescript declaration files #56

Closed naxmefy closed 7 years ago

naxmefy commented 7 years ago

could you create some?

dlau commented 7 years ago

Hi, yes typescript bindings would definitely be useful.

I'm a bit crushed with work at the moment-- I'll get to this when I have a chance. In the meantime feel free to submit a pr.

weicracker commented 7 years ago

https://github.com/weicracker/-types-koa-body

this is my using

naxmefy commented 7 years ago

@weicracker on https://github.com/weicracker/-types-koa-body/blob/master/index.d.ts#L41 you wrote onerror but it seems to be onError. Is this a problem?

@dlau I will add a PR for this issue

blaesus commented 7 years ago

@dlau @naxmefy How's the ts definition PR going through? I see the PR is a month-old now. Is there something I can help with?

naxmefy commented 7 years ago

@andyblaesus i dont know - @dlau have to merge it if he wants it

dlau commented 7 years ago

Sorry for the delay, merging!

dlau commented 7 years ago

Live in 2.4.0

blaesus commented 7 years ago

@dlau Hmm, when I npm install koa-body, I don't get the index.d.ts. I did get the 2.4.0 version though. Am I doing something wrong? Thanks!

blaesus commented 7 years ago

Never mind, it seems to work now. Thanks you for the efforts!