search

koajs / koa-hbs

Handlebars templates for Koa.js
MIT License
160 stars 43 forks source link

Next #61

Closed Mirodil closed 7 years ago

Mirodil commented 7 years ago

for koa2

shellscape commented 7 years ago

thanks for the PR! just got back into town from the holidays 🎅 , will have a look tomorrow. (had a quick look. looks like your editor changed a bunch of spacing. please revert those real quick. I'll walk through the tests and such tomorrow, to clarify)

fiftyfactorauthentication commented 7 years ago

@Mirodil looks good, but needs the render tests to be updated for async. that's the only blocker on merging this.

fiftyfactorauthentication commented 7 years ago

@Mirodil why did you remove all spaces?

"please don't refactor spacing and style" only meant to not modify existing spacing/formatting/code style.

I'm sorry, but I can't accept this PR in it's current state. Please revert to HEAD, reapply your async changes, adhering to the existing code style in HEAD, and push to the PR.

shellscape commented 7 years ago

@Mirodil ping

Mirodil commented 7 years ago

I think, we can close this pull request

shellscape commented 7 years ago

ok will do. we'll cherry pick the changes and give you credit for them.