[WIP] Replace koa-generic-session with koa-session

koajs / koa-redis

Redis storage for Koa session middleware/cache with Sentinel and Cluster support

MIT License

352 stars 40 forks source link

[WIP] Replace koa-generic-session with koa-session #46

Closed nicklaw5 closed 1 year ago

nicklaw5 commented 6 years ago

Note: This is a work in progress. I'm open to discussion for specific implementation whilst I continue to make minor changes and improvement to tests and test coverage.

Migrating from koa-generic-session to koa-session is a major breaking change. This implementation uses Node's util.promisify function for converting a callback-based function to a Promise-based one, which means Node v8+ is required.

These changes also:

converted all generators to async/await functions
dropped backward compatibility for options.socket and options.pass
updated all existing tests and removed obsolete async-specific tests
replaced istanbul with nyc to support ES6 syntax code coverage
had RedisStore extend EventEmitter, since that is the preferred method when using class inheritance
added eslint for linting

Closes #35

coveralls commented 6 years ago

Coverage decreased (-6.1%) to 93.902% when pulling fea46f8bec9efad61ce28810275c6516f631a6e0 on nicklaw5:v4-support-koa-session into af55af3ea574e4fdbe5ab086054ee9b0ed9ab509 on koajs:master.

coveralls commented 6 years ago

Coverage decreased (-6.1%) to 93.902% when pulling fea46f8bec9efad61ce28810275c6516f631a6e0 on nicklaw5:v4-support-koa-session into af55af3ea574e4fdbe5ab086054ee9b0ed9ab509 on koajs:master.

coveralls commented 6 years ago

Coverage decreased (-6.1%) to 93.902% when pulling 35838c520607d7ee84ed7afce8cc5e411f44ecac on nicklaw5:v4-support-koa-session into af55af3ea574e4fdbe5ab086054ee9b0ed9ab509 on koajs:master.

nicklaw5 commented 6 years ago

@dead-horse @DaAwesomeP Is there any possibility of having one (or both) of you review this?

edevil commented 6 years ago

Thanks for your work, I hope it gets merged.

smashercosmo commented 5 years ago

Is there anything I can do to help to get this merged?

nicklaw5 commented 5 years ago

@smashercosmo I would happily finish this off, but I would first appreciate a review from one of the maintainers of this library.

smashercosmo commented 5 years ago

ping @dead-horse @DaAwesomeP

niftylettuce commented 5 years ago

@nicklaw5 could you please see latest v4.0.0 in master branch and submit a new PR?

Max-Starling commented 5 years ago

Any updates on this?

nicklaw5 commented 5 years ago

I can possibly take a look at this over the weekend :slightly_smiling_face:

smashercosmo commented 5 years ago

friendly ping @nicklaw5

nicklaw5 commented 5 years ago

My apologies, I haven't had the time to look at this. I don't see me having the time to look at it anytime soon either. Happy for someone else to continue on where I left off.

insidewhy commented 5 years ago

Fix in https://github.com/koajs/koa-redis/pull/56 together with proper expiry support. Also replaced generators with async/await and added TypeScript support. Published as koa-redis-snowman. Happy to merge upstream.