search

koajs / koa-redis

Redis storage for Koa session middleware/cache with Sentinel and Cluster support
MIT License
352 stars 40 forks source link

chore: move from koa-generic-session to koa-session (#35) #56

Closed insidewhy closed 5 years ago

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 97.345% when pulling 185e24ebdf1dd5bd92e755ae36095b3cdfd324b9 on ohjames:jpike/koa-session into 5c1c109b8eb46d6589efa815e92277bd3d80ebe0 on koajs:master.

wong2 commented 5 years ago

@niftylettuce @dead-horse please merge this

smashercosmo commented 4 years ago

@niftylettuce any ETA on publishing version with these changes?

niftylettuce commented 4 years ago

@smashercosmo see my comment here https://github.com/koajs/koa-redis/issues/35#issuecomment-571536410

niftylettuce commented 4 years ago

I am not merging this right now because I don't recommend koa-session at the moment, since it does not support a saveSession method as similar to koa-generic-session currently does - which affects functionality when compared to express-session, which modifies session (saves) on res.end overwrite.

smashercosmo commented 4 years ago

@niftylettuce thx for the explanation