Server-side triggering of acknowledgements in routes

koajs / koa.io

[MAINTAINERS WANTED] Realtime web framework combine koa and socket.io.

429 stars 52 forks source link

Server-side triggering of acknowledgements in routes #15

Closed tiagosr closed 9 years ago

tiagosr commented 9 years ago

Quite simple fix for dealing with client acknowledgement. Now users can use a callback function in client code to receive immediate feedback on a given route.

ariporad commented 9 years ago

Hey, I commented this, but it looks like you're not actually handling the error. Is that intentional?

ariporad commented 9 years ago

Hey, Could you merge master into your fork? It's behind, and there are merge conflicts. If the tests pass after that, I'll merge it.

ariporad commented 9 years ago

Sorry, one more thing: According to GitHub, you haven't changed anything: screenshot

tiagosr commented 9 years ago

@ariporad I was aware of it, but it looks like somebody else made similar changes to mine recently - I could see the places I made the changes, but the merge went without it being any kind of conflict.

ariporad commented 9 years ago

Ok, Then I'm going to close this.