search

koajs / koa.io

[MAINTAINERS WANTED] Realtime web framework combine koa and socket.io.
429 stars 51 forks source link

It seems that co-event-wrap module is not used? #3

Closed dzcpy closed 9 years ago

dzcpy commented 9 years ago

So can we remove it as dependency?

travisjeffery commented 9 years ago

yeah looks like it, would just need to remove this line as well: https://github.com/koajs/koa.io/blob/b421b205bdd5770addbe78a731044ce21e060ca3/lib/socket.io/socket.js#L16. wrap isn't used.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.12%) to 74.55% when pulling b7fe28cfda5e818fe7a5734b4fc9f4b2ed73785a on remove/co-event-wrap into b421b205bdd5770addbe78a731044ce21e060ca3 on master.

dead-horse commented 9 years ago

thanks! I don't have enough time to complete this module now. :(