Dependency to `any-promise` still exists, which has a global leak issue

koajs / koa

Expressive middleware for node.js using ES2017 async functions

https://koajs.com

MIT License

35.25k stars 3.23k forks source link

Dependency to `any-promise` still exists, which has a global leak issue #1228

Closed srmcconomy closed 6 years ago

srmcconomy commented 6 years ago

this was supposed to be fixed with https://github.com/koajs/koa/issues/945, and it was fixed in koa-compose. But koa-convert still has a dependency to an old version of koa-compose so koa still depends on any-promise

fl0w commented 6 years ago

You are correct. The thing about removing any-promise is that it's breaking. This'll be fixed when there's a Koa 3 release as 1) koa-compose will be bumped and 2) koa-convert will be removed.

I'm going to close this as this is known and doesn't really raise a new issue.