search

koajs / koa

Expressive middleware for node.js using ES2017 async functions
https://koajs.com
MIT License
35.13k stars 3.23k forks source link

Node 4.x, 7.x and 9.x are end-of-life #1233

Closed meteorlxy closed 6 years ago

meteorlxy commented 6 years ago

See https://github.com/nodejs/Release#end-of-life-releases

Should we remove support/suggestion for them?

From

https://github.com/koajs/koa/blob/41257aa91e437149112668dd018aaa2081f98d0d/package.json#L60

To

"node": "^6.10.1 || ^8.1.4 || 10.x.x"

(Couldn't determine which semver of v10 should we choose)

BTW, the docs wrote:

Koa requires node v7.6.0 or higher for ES2015 and async function support.

As we do not really "require" v7.6.0, should the docs be changed to suggests node v7.6.0 or higher?

fl0w commented 6 years ago

The engines defined in package.json isn't following the LTS scheme, it's minimum requirements. If someone uses node.js 4.x with Koa, it only helps user to not use a vulnerable build (refer to node.js security blogs).

If Koa uses features that require newer version this will be updated.