koajs / koa

Expressive middleware for node.js using ES2017 async functions
https://koajs.com
MIT License
35.24k stars 3.23k forks source link

Replacing eslint with standard cli #1796

Closed etroynov closed 10 months ago

etroynov commented 10 months ago

Hi,

While working on one of the plugins for koa which is used in our company I needed to study some points in the Koa source code, during the installation of dependencies I noticed deprecating warnings.

In the course of studying the project's dependencies I found:

why not just update eslint?

I can see several reasons why the official utility is better than the eslint custom config ( in my opinion ofc ):

Checklist

socket-security[bot] commented 10 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
snazzy 9.0.0 None +7 247 kB feross
standard 17.1.0 None +143 16.4 MB voxpelli

🚮 Removed packages: eslint@7.32.0, eslint-config-standard@16.0.3, eslint-plugin-import@2.26.0, eslint-plugin-node@11.1.0, eslint-plugin-promise@5.2.0, eslint-plugin-standard@5.0.0

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5ba533f) 98.66% compared to head (4db592c) 98.66%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1796 +/- ## ======================================= Coverage 98.66% 98.66% ======================================= Files 5 5 Lines 523 523 Branches 146 146 ======================================= Hits 516 516 Misses 7 7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

etroynov commented 10 months ago

@dead-horse, @fengmk2

Can you take a look?

etroynov commented 9 months ago

@fengmk2 thx a lot :)