search

koajs / koala

[SEEKING MAINTAINER] An HTTP/2 and ES6 Module-ready Koa Suite
MIT License
320 stars 27 forks source link

Support Koa 2.0 #47

Closed doug-wade closed 6 years ago

doug-wade commented 7 years ago

Fixes #17. Tested against http://github.com/doug-wade/koala-example

nickserv commented 7 years ago

Wow, nice work, thanks! I'll try to do a detailed review tonight or tomorrow.

nickserv commented 7 years ago

I pushed some minor fixes here. I also made an additional pull request based against this one so you could review the change separately, it converts Koala to a class to match Koa 2's usage https://github.com/doug-wade/koala/pull/1.

I'm having a hard time fixing the 404/500 errors in the test failures, can you take a look when you have a chance? We should also drop this in middleware functions and consider not checking the test value of NODE_ENV (see https://github.com/koajs/koa/blob/master/docs/migration.md).

doug-wade commented 6 years ago

yo @nickmccurdy @bhaskarmelkani, I think this one's ready to merge. I'd appreciate a once-over if you've got a sec.

bhaskarmelkani commented 6 years ago

Hey,

Thanks for the updates. I completely missed the notification for your message.

Looks good to me :)