search

koajs / ratelimit

Rate limiter middleware
MIT License
485 stars 57 forks source link

Update to koa 2 #21

Closed dzcpy closed 7 years ago

haoxins commented 8 years ago

CI failed :)

dzcpy commented 8 years ago

It should pass the tests nnow

dead-horse commented 8 years ago

it better to create a next branch to support koa@2.

and personally -1 to rewrite with raw promise(without async await). can't we just use koa-convert to support koa@2 now?

dzcpy commented 8 years ago

Well, what do you mean raw promise? There's no additional Promise libraries used nor native Promise. Just thenify which already exists since v1.

dead-horse commented 8 years ago

actually I'm dislike direct using promise in koa's middleware, It was design for async await. I'd rather using generator function for now(without async await being native).

haoxins commented 7 years ago

closed by #26