koajs / ratelimit

Rate limiter middleware
MIT License
485 stars 57 forks source link

Some enhancements - koa-better-ratelimit #5

Closed tunnckoCore closed 10 years ago

tunnckoCore commented 10 years ago

Hi folks.

What think for this memory-only-for-now store implementation - koa-better-ratelimit with only 4 dependencies? I know it's near between koa-limit and koa-ratelimit, but I think it's smaller and rationally better than koa-limit that is totally broken for me.

There's no db option, cuz I don't need other than in-memory.

Diferences

Between koa-better-ratelimit and koa-ratelimit

If you want you can add to wiki page :)

tj commented 10 years ago

should easily be different middleawre

not useful for real applications, maybe during dev but that's it

milliseconds is basically standard in js

Globik commented 7 years ago

Hi @tunnckoCore , how to use your middleware in practice? Yes, I see an example provided by you. But not understanble enough how to handle all those custom errors. Shoud it be hanled in a router system?

tunnckoCore commented 7 years ago

haha, pretty old issue bumped.

@Globik, i'm working on v3. Actually it is almost ready and it is in the master branch. But was busy last month or so. It is pretty working and it is for Koa2.

Please open issue there and explain, give some examples and etc.

Globik commented 7 years ago

Ok, @tunnckoCore I'll look at v3.