Tests & Deps update - Githubissues

etroynov commented 2 years ago

Checklist

[x] I have ensured my pull request is not behind the main or master branch of the original repository.
[x] I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
[x] I have written a commit message that passes commitlint linting.
[x] I have ensured that my code changes pass linting tests.
[x] I have ensured that my code changes pass unit tests.
[x] I have described my pull request and the reasons for code changes along with context if necessary.

etroynov commented 2 years ago

@niftylettuce can you check my PR? Thx.

p.s sry for the direct message by reviewers for PR not available :(

etroynov commented 2 years ago

@3imed-jaberi @jmealo @dominicegginton can you review?

SagnikPradhan commented 2 years ago

I get your enthusiasm, but pinging random people is not helpful. Your PR won't get merged either way if none of the official contributors respond.

etroynov commented 2 years ago

@SagnikPradhan why random? I checked the previous PR and found these people gave approvals or merged PR

titanism commented 2 years ago

We have just published @koajs/router v11.0.0 which resolves this issue. This is mirrored to koa-router as well.

This project is maintained by Forward Email and Lad.