VERSION: update minimal version from 8 -> 12

etroynov commented 2 years ago

Hi,

According to error log I found what some of our deps require minimal node version 12 koa_1

Deps ( minimal node version )

koa - 12 (link )
koa-convert - 10 (link)

I installed node.js version 8 and tried run tests: koa_2

For this reason, I thought it was necessary to raise the node version from 8 -> 12

Checklist

[x] I have ensured my pull request is not behind the main or master branch of the original repository.
[x] I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
[x] I have written a commit message that passes commitlint linting.
[x] I have ensured that my code changes pass linting tests.
[x] I have ensured that my code changes pass unit tests.
[x] I have described my pull request and the reasons for code changes along with context if necessary.

etroynov commented 2 years ago

@niftylettuce @3imed-jaberi what do you think about it?

SagnikPradhan commented 2 years ago

Since v14 is the last maintained node version, you could set it to that.

etroynov commented 2 years ago

@SagnikPradhan yes but in koa minimal version set as 12, for this reason, I decided to set the same version because it will be strange if the router will use version 14.

titanism commented 2 years ago

We have just published @koajs/router v11.0.0 which resolves this issue. This is mirrored to koa-router as well.

https://github.com/koajs/router/releases/tag/v11.0.0

This project is maintained by Forward Email and Lad.

koajs / router

VERSION: update minimal version from 8 -> 12 #152

Checklist