Closed peterver closed 2 years ago
this is an adjusted version of #147 with unit tests added for correctness
@peterver hi you can change [v] -> [x] and list will be look like here: https://github.com/koajs/router/pull/153
@wengeezhang could you check it?
@peterver I suppose it's not good approach make PR from master
to master
, maybe you should create separate branch for it.
@peterver I suppose it's not good approach make PR from
master
tomaster
, maybe you should create separate branch for it.
Apologies, first contribution here and want to get going :D I'm used to working in a git-flow approach (develop/master) and wasn't sure about the proper practice here :). Will adhere for future PR's thanks!
@etroynov I've opened a new PR #155 with all of the above adjustment requests included :). PS: there were 1 or 2 additional uses of double quote over single quote, I've gone ahead and changed those as well, thanks for ensuring code style :)
We have just published @koajs/router
v11.0.0 which resolves this issue. This is mirrored to koa-router
as well.
https://github.com/koajs/router/releases/tag/v11.0.0
This project is maintained by Forward Email and Lad.
…ion checks
Checklist