search

koajs / router

Router middleware for Koa. Maintained by @forwardemail and @ladjs.
MIT License
871 stars 176 forks source link

Added eslint and formatted package #2

Closed divmgl closed 5 years ago

divmgl commented 5 years ago

Merge after https://github.com/koajs/koa-router/pull/1 @dead-horse

dead-horse commented 5 years ago

I'd like to keep the style as original for now, people can migrate PR's from koa-router much easier

divmgl commented 5 years ago

Okay I'll make the changes

divmgl commented 5 years ago

@dead-horse there was very little consistency in the codebase so it's going to be tricky to create the perfect set of eslint rules. For now, I've added back semi-colons so the pull request should be much more readable. Let me know your thoughts.

divmgl commented 5 years ago

Can we get this merged so all pull requests going forward have a formatting style? @dead-horse

divmgl commented 5 years ago

@dead-horse ?

niftylettuce commented 5 years ago

Thanks for PR - I will be integrating prettier/xo setup from https://lass.js.org into this project. If you're interested in this approach and get time before I do, you could practically clone my work/setup I have done in projects like https://github.com/cabinjs/parse-logs.