search

koajs / router

Router middleware for Koa. Maintained by @forwardemail and @ladjs.
MIT License
871 stars 176 forks source link

Add test for optional route parameter #43

Closed smarts closed 4 years ago

smarts commented 4 years ago

Test for #40

smarts commented 4 years ago

Sure. Both styles were in the code already, so @3imed-jaberi how would you feel about me doing a sweep and fixing it everywhere in this file? On an unrelated note as a bit of constructive criticism: in the future, a simple . or ? is probably better. Using !! comes across a bit aggressive and could alienate contributors.

niftylettuce commented 4 years ago

@smarts no worries - they didn't mean to alienate in any way, @3imed-jaberi is excited and happy to see your contributions! 🎉 🎉

smarts commented 4 years ago

Interesting, this test passes now. Looks like the bug has been fixed.

niftylettuce commented 4 years ago

thanks @smarts

smarts commented 4 years ago

Happy to help. Thanks to you @niftylettuce and @3imed-jaberi as well!

3imed-jaberi commented 4 years ago

@smarts, sorry ... I didn't mean to insult or belittle or anything negative ... I just tried to provide a comment summarizing the situation in this PR and I wanted to say thank you for your contribution and that your work provides a good example ..