Test Coverage Improved - Githubissues

koajs / router

Router middleware for Koa. Maintained by @forwardemail and @ladjs.

MIT License

871 stars 176 forks source link

Test Coverage Improved #64

Closed JacobMGEvans closed 4 years ago

JacobMGEvans commented 4 years ago

The layer has been increased to all 100's coverage
The router has had an additional logic control flow line covered reducing uncovered lines from 4 to 3
Rebase SUCCESS! 🎉🎊funny enough my Prettier added a CRLF line to a file @niftylettuce

JacobMGEvans commented 4 years ago

@niftylettuce Since I don't have the option to squash the PR I did it manually and created this new PR I'll try to keep the forked branches up to date with the upstream master, doing stuff like this a little new to me for lol

niftylettuce commented 4 years ago

Any chance you could update this one more before I merge it @JacobMGEvans ?

JacobMGEvans commented 4 years ago

Hmm, seems to be a lot of changes since this PR. Are most of the tests currently passing in your master branch?

JacobMGEvans commented 4 years ago

I think Travis needs to have a Test check for PR's??

JacobMGEvans commented 4 years ago

Currently if I pull in remote(upstream) master into my master and run the tests I get this. Thats resolving the merge conflict with accepting incoming changes ("theirs").

3imed-jaberi commented 4 years ago

@JacobMGEvans, thank u for your PR. I'm going to work on this.

niftylettuce commented 4 years ago

v9.0.1 released https://github.com/koajs/router/releases/tag/v9.0.1