Closed Sinewyk closed 4 years ago
Upgrade path-to-regexp from 1.x to ^6.x
path-to-regexp
then:
x => x
compile
path-to-regexp@2.0
path === '/'
should fixes #40
should be a straight upgrade over https://github.com/koajs/router/pull/70
Maybe breaking change (major semver) related to the encode/decode situation.
v9.0.0 released to npm
https://github.com/koajs/router/releases/tag/v9.0.0
Ping @Sinewyk @tigt -- can you resolve/PR?
Upgrade
path-to-regexp
from 1.x to ^6.xthen:
path-to-regexp
encode/decode being by default the identity functionx => x
... send the options tocompile
and be explicit in the testspath-to-regexp@2.0
breaking change regarding explicit trailing slash handling https://github.com/pillarjs/path-to-regexp/blob/0c466b1b0944e8d0022b5b15069364a8483bf9c5/History.md#200--2017-08-23 ... I added tests, it should not be a breaking change for us because I added a specific behavior whenpath === '/'
and prefix, we can target trailing slash by using the strict option.should fixes #40
should be a straight upgrade over https://github.com/koajs/router/pull/70
Maybe breaking change (major semver) related to the encode/decode situation.