search

koalalorenzo / python-digitalocean

🐍🐳 Python module to manage Digital Ocean droplets
GNU Lesser General Public License v3.0
1.26k stars 301 forks source link

Get deleted Droplet results in digitalocean.NotFoundError #271

Closed raceybe closed 5 years ago

raceybe commented 5 years ago

When get_droplet() is run on an id for a deleted droplet, a digitalocean.NotFoundError results. Instead of throwing the error, can it be modified to return a null droplet, or similar?

koalalorenzo commented 5 years ago

This is following the API implementation, so if the API is throwing an error, it should do the same.

What is the case, issue, pain you are having with the current implementation?

raceybe commented 5 years ago

That's a fair response. Originally I was expecting a None result, but I now see that doesn't make sense. I'll close the issue.