search

koalalorenzo / python-digitalocean

🐍🐳 Python module to manage Digital Ocean droplets
GNU Lesser General Public License v3.0
1.25k stars 300 forks source link

get_account() fails #317

Closed ghost closed 1 year ago

ghost commented 4 years ago

It looks like Digital Ocean removed the account/ URL and now it's just account. account/ 404s.

Have to update https://github.com/koalalorenzo/python-digitalocean/blob/master/digitalocean/Account.py#L28

The docs also say /account and not /account/, so I think this is incorrect on our end.

I can open a PR if you want.

koalalorenzo commented 3 years ago

I am not sure if the issue persists. Could you double-check with the latest version (1.16.0)? The following code works fine:

import digitalocean
manager = digitalocean.Manager(token="abc")
manager.get_account()
# AND
a = digitalocean.Account(token=manager.token)
a.load()
ghost commented 3 years ago

Could you release a new version with the balance PR that you just merged in? I need that code as well. If not, I should be able to test this directly.

koalalorenzo commented 3 years ago

Uhm, I think v1.16.0 includes it already. Are you running the latest version? (Maybe I have done something wrong... but please check, according to the logs v1.16 includes it)

ghost commented 3 years ago

My bad, I totally misread the commits. Let me give it a try.

koalalorenzo commented 3 years ago

btw, thanks for helping :)

koalalorenzo commented 1 year ago

Closing for inactivity! Feel free to comment or open a new one if needed!