search

koalalorenzo / python-digitalocean

🐍🐳 Python module to manage Digital Ocean droplets
GNU Lesser General Public License v3.0
1.26k stars 301 forks source link

Updating & Deleting Domain Records (Tests Included Edition) #332

Closed new-guy closed 3 years ago

new-guy commented 3 years ago

I added tests to pr #275. Lemme know if there is anything that should be changed.

Also I modified the dockerfile so that it would install python packages prior to adding the rest of the source - this allows cache hits on package install rather than having to go through that process every time code is changed.

new-guy commented 3 years ago

Happy to get rid of the dockerfile changes if y'all prefer to avoid having this sort of thing in PRs. It saves around 2 seconds per test run on my machine, which isn't that crazy, but it was a simple change to make :)