search

koalalorenzo / python-digitalocean

🐍🐳 Python module to manage Digital Ocean droplets
GNU Lesser General Public License v3.0
1.25k stars 300 forks source link

Add CDN Endpoint API to create, update and delete. #349

Closed ajite closed 1 year ago

ajite commented 2 years ago

Updated manager to do not submit body params during request when params argument was set to False.

        if params is False:
            del kwargs['data']

The API will return an error when submitting params (even empty).

The default behaviour sets the “params" to an empty dict when its value is equal to None.

        if params is None:
            params = dict()

This does not work with the CDN Enpoints API. I did not want to change this behaviour since it was probably made because other API endpoints needed a body (even if empty).

I am aware that is not the most elegant solution though.

koalalorenzo commented 2 years ago

Interestingly, no workflow started :O I'll look into it so that tests will work

koalalorenzo commented 1 year ago

@ajite could you try adding a commit that would trigger the tests again? 🤔

ajite commented 1 year ago

Hi,

I merged the main branch new content to my PR. It seems to have triggered github actions. I wrote that PR a while ago, I am not sure how relevant it still is.