Domain.create_new_domain_record ttl kwarg is ignored - Githubissues

koalalorenzo / python-digitalocean

🐍🐳 Python module to manage Digital Ocean droplets

GNU Lesser General Public License v3.0

1.26k stars 301 forks source link

Domain.create_new_domain_record ttl kwarg is ignored #350

Closed alexzorin closed 2 years ago

alexzorin commented 2 years ago

Hi,

In create_new_domain_record, this package is overriding the ttl kwarg, which comes from the domain's overall TTL (from SOA):

https://github.com/koalalorenzo/python-digitalocean/blob/ebea58fddf2ceea35c027bfa66f2fa9f5debfd64/digitalocean/Domain.py#L83-L84

which is populated earlier here:

https://github.com/koalalorenzo/python-digitalocean/blob/ebea58fddf2ceea35c027bfa66f2fa9f5debfd64/digitalocean/Domain.py#L24-L30

Consequently, the ttl kwarg is ignored.

This affects https://github.com/certbot/certbot/pull/9149.

koalalorenzo commented 2 years ago

Closing for inactivity! Feel free to comment or open a new one if needed!