koalaman / shellcheck

ShellCheck, a static analysis tool for shell scripts
https://www.shellcheck.net
GNU General Public License v3.0
36.38k stars 1.78k forks source link

CircleCI Orb #1947

Closed elreydetoda closed 4 years ago

elreydetoda commented 4 years ago

For new checks and feature suggestions

Comment

Additional Arg

I was just curious if it would be possible to add another option to pass to shellcheck for the CircleCI orb. If the additional option allowed any extra args (i.e. -o for optional checks) then it would allow more flexibility for use of the CircleCI orb, and allow for less maintenance because you wouldn't have to create an additional parameter in the orb. An example of such argument that gets interpreted the same way is the snyk orb they have an option called additional-arguments which allows for arbitrary flags to be passed.

I tried to do a quick search for the code that is used to generate the CircleCI stuff and I couldn't find it, but if you do have it somewhere I would love to submit a PR so you wouldn't have to worry about it.

Thanks for such an awesome project! :tada: :grin:

elreydetoda commented 4 years ago

I am so sorry...I didn't realize that orb is something that circle ci put together and it wasn't this project who maintained it... I am so sorry! :sweat: