search

koalazak / dorita980

Unofficial iRobot Roomba and Braava (i7/i7+, 980, 960, 900, e5, 690, 675, m6, etc) node.js library (SDK) to control your robot
MIT License
932 stars 147 forks source link

Roomba s9+ rooms #117

Closed cecton closed 3 years ago

cecton commented 4 years ago

On the s9+ as of today the rooms are designated as follow:

    {
      "region_id": "7",
      "type": "rid",
    }

The type seems to always be rid. Only region_id varies and is a stringified number.

(I'm just putting this for others, you can close this issue)

binomialstew commented 3 years ago

I also see this format when I check thelastCommand state. Unfortunately, I have been unable to get cleanRooms to run using this or the old format with firmware 3.8.3 on a Braava Jet m6.

binomialstew commented 3 years ago

I was using a string for "ordered" when it should have been an integer 1. This works now, but I also have omitted the "type" property in my request args as per @jeremywillans suggestion:

const args = {
  "ordered": 1,
  "regions": [
    {
      "region_id": "11"
    },
    {
      "region_id": "1"
    }
  ],
  "pmap_id": "xxxxxxxxxxxxxxxxxxxxxxxxx",
  "user_pmapv_id": "xxxxxxxxxxxxxxx"
};
koalazak commented 3 years ago

this impacts some how what we have in the current README.md about cleanRoom method? we should change something in the readme? sorry I do not own a s9+ to test it.

binomialstew commented 3 years ago

I think warki's PR takes care of it

cecton commented 3 years ago

Please, it was an issue dedicated to Roomba S9+ in particular so people can find the information easily :sweat_smile: