koalazak / dorita980

Unofficial iRobot Roomba and Braava (i7/i7+, 980, 960, 900, e5, 690, 675, m6, etc) node.js library (SDK) to control your robot
MIT License
964 stars 149 forks source link

Update to readd pose to mission; add seperate pose call #161

Closed SageKaz closed 1 year ago

SageKaz commented 2 years ago

Pose appeared to be removed with a previous update from mission output. This broke compatibility with rest980.

In addition I added a separate method to get just pose information.

SageKaz commented 2 years ago

Reading through the commit this was removed in and I did notice a comment about some firmware not reporting pose which may be why this was removed. Perhaps removing the portion to add it back to the mission info, but maintaining the new endpoint would be better in this case.

SageKaz commented 2 years ago

Revisiting your documentation it seems this is actually the correct way to handle this. Devices that don't have pose information available anymore should probably use the getBasicMission() call instead for the time being.