search

koalazak / rest980

REST interface to control your iRobot Roomba 980 via local server on your lan.
MIT License
293 stars 62 forks source link

Allow passing of additional arguments to actions #41

Closed mindstorms6 closed 4 years ago

mindstorms6 commented 5 years ago

This change is a follow on from the dorita980 change - this allows users to use the rest API to start a room specific cleaning.

This is done by accepting POST requests for actions, and attempting to pass req.body (as json) if present to the underlying call to dorita.

Tested by starting a room specific cleaning by the API locally :)

mindstorms6 commented 4 years ago

Hey @koalazak !

Just a gentle ping on this - would love your thoughts (and the related change in dorita980 )

I'm happy to make any needed changes if you'd like.

Thanks again for the library.

koalazak commented 4 years ago

thanks a lot for your contribution!

koalazak commented 4 years ago

also, can you pump the package version? and add some documentation to the readme?

thank you!

mindstorms6 commented 4 years ago

This should be ready for review now too :)