koalyptus / TableFilter

A Javascript library making HTML tables filterable and a bit more :)
https://www.tablefilter.com
MIT License
324 stars 94 forks source link

fix TableFilter table id generation with more robust uuid generator #685

Closed koalyptus closed 5 years ago

koalyptus commented 5 years ago

Description

Fix issue described in #679 by implementing a simple and good enough uuid generator.

Type of change

Checklist:

codecov[bot] commented 5 years ago

Codecov Report

Merging #685 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #685      +/-   ##
==========================================
+ Coverage    88.8%   88.81%   +0.01%     
==========================================
  Files          39       39              
  Lines        4500     4505       +5     
  Branches      301      301              
==========================================
+ Hits         3996     4001       +5     
  Misses        486      486              
  Partials       18       18
Impacted Files Coverage Δ
src/string.js 95% <100%> (+0.71%) :arrow_up:
src/tablefilter.js 93.3% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0a69a99...495b64e. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #685 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #685      +/-   ##
==========================================
+ Coverage    88.8%   88.81%   +0.01%     
==========================================
  Files          39       39              
  Lines        4500     4505       +5     
  Branches      301      301              
==========================================
+ Hits         3996     4001       +5     
  Misses        486      486              
  Partials       18       18
Impacted Files Coverage Δ
src/string.js 95% <100%> (+0.71%) :arrow_up:
src/tablefilter.js 93.3% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0a69a99...495b64e. Read the comment docs.