koalyptus / TableFilter

A Javascript library making HTML tables filterable and a bit more :)
https://www.tablefilter.com
MIT License
324 stars 95 forks source link

clear_filter_text is not applied #714

Closed dset0x closed 5 years ago

dset0x commented 5 years ago

Describe the bug Setting clear_filter_text has no effect on the Clear text.

Reproduction steps: Steps to reproduce the behavior:

  1. Set clear_filter_text to an array in your configuration. Example
  2. var table_filter = new TableFilter(document.querySelector('.units-index-table'), tf_config);

Expected behavior table_filter.clearFilterText is "Clear"

Observed behavior: table_filter.clearFilterText is not "Clear"

TableFilter version: 0.6.89 Browser and version: Firefox 66 OS and version: Linux Device: My laptop. Also your laptop. Well, I hope you can reproduce it.

Additional information/context: Issue also seems to occur here: https://www.tablefilter.com/external-filters.html

koalyptus commented 5 years ago

Tx @dset0x for pointing this out, it will be fixed in the next version(s).

koalyptus commented 5 years ago

@dset0x it should be fixed starting from v0.6.92. Let me know how it goes. Reminder: this option only applies to select, multiple and checklist filters. Cheers

dset0x commented 5 years ago

Fantastic! Thanks so much, @koalyptus.