koalyptus / TableFilter

A Javascript library making HTML tables filterable and a bit more :)

https://www.tablefilter.com

MIT License

324 stars 94 forks source link

Enhance filter options sorting based on column data type #722

Closed koalyptus closed 5 years ago

koalyptus commented 5 years ago

Description

Based on #716 enhance filter options sorting based on column's data type. Note sort_num_asc and sort_num_desc options are obsoleted in favour of more generic sort_filter_options_asc and sort_filter_options_desc settings.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes do not lower current test coverage
[x] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

codecov[bot] commented 5 years ago

Codecov Report

Merging #722 into master will increase coverage by 0.24%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #722      +/-   ##
==========================================
+ Coverage   88.82%   89.06%   +0.24%     
==========================================
  Files          39       39              
  Lines        4493     4501       +8     
  Branches      311      326      +15     
==========================================
+ Hits         3991     4009      +18     
+ Misses        484      475       -9     
+ Partials       18       17       -1

Impacted Files	Coverage Δ
src/tablefilter.js	`93.48% <100%> (+0.05%)`	:arrow_up:
src/modules/baseDropdown.js	`98.21% <100%> (+6.98%)`	:arrow_up:
src/sort.js	`100% <0%> (+23.07%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2e1af5e...78ae09c. Read the comment docs.