koalyptus / TableFilter

A Javascript library making HTML tables filterable and a bit more :)
https://www.tablefilter.com
MIT License
323 stars 95 forks source link

Fix for #772: help instructions pop-up position with responsive behaviour #780

Closed koalyptus closed 4 years ago

koalyptus commented 4 years ago

Description

As described in #772, fix help instructions positioning when responsive behaviour is on and working table element features a horizontal scrollbar. This also adds a help_instructions.container_adjust_left_position setting allowing pop-up positioning pixel adjustments if needed.

Type of change

Checklist:

codecov[bot] commented 4 years ago

Codecov Report

Merging #780 into master will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #780      +/-   ##
==========================================
+ Coverage   89.06%   89.09%   +0.03%     
==========================================
  Files          39       39              
  Lines        4500     4504       +4     
  Branches      325      327       +2     
==========================================
+ Hits         4008     4013       +5     
  Misses        475      475              
+ Partials       17       16       -1     
Impacted Files Coverage Δ
src/dom.js 84.61% <ø> (ø)
src/modules/help.js 90.62% <100.00%> (+1.49%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 577fb0b...8633891. Read the comment docs.