koalyptus / TableFilter

A Javascript library making HTML tables filterable and a bit more :)
https://www.tablefilter.com
MIT License
324 stars 95 forks source link

Allow to remove copy right notice by setting help_instructions value #788

Closed lijieyin closed 3 years ago

lijieyin commented 3 years ago

Enhancement/feature description Allow to remove copy right notice by setting help_instructions value

Steps which explain the enhancement/feature

  1. When click on "?/Help" to pop up help information, at the bottom of the pop up window, a URL and a copy right information are shown as in the image below, currently you allows us to set help_instructions to provide customized help information, however the copyright and URL cannot be overridden unless directly modify the tablefilter.js file, is it possible to allow us to remove this URL and copy right information by setting help_instructions value?

Current and suggested behavior [Describe current and suggested behavior here]

Why would the enhancement be useful to most users

Screenshots and GIFs image

Additional context

Describe alternatives you've considered

TableFilter Version: [Enter TableFilter version here]

koalyptus commented 3 years ago

Please note you can use the defaultHtml property on the Help instance to modify the instructions footer, ie:

var tf = new TableFilter('my-table-id', myTfConfig);
var help = tf.feature('help');
help.defaultHtml = '';
tf.init();

Refer to http://www.tablefilter.com/docs/class/src/modules/help.js~Help.html#instance-member-defaultHtml

lijieyin commented 3 years ago

Thank you very Koalyptus, it works perfectly.

Regards Lijie YIN


From: koalyptus notifications@github.com Sent: Friday, August 28, 2020 8:28 PM To: koalyptus/TableFilter TableFilter@noreply.github.com Cc: Li-Jie Yin Li-Jie.Yin@ir.com; Author author@noreply.github.com Subject: Re: [koalyptus/TableFilter] Allow to remove copy right notice by setting help_instructions value (#788)

[External Email] Please note, this email was sent from outside IR - be cautious particularly with links and attachments.

Please note you can use the defaultHtml property on the Help instance to modify the instructions footer, ie:

var tf = new TableFilter('my-table-id', myTfConfig); var help = tf.feature('help'); help.defaultHtml = ''; tf.init();

Refer to http://www.tablefilter.com/docs/class/src/modules/help.js~Help.html#instance-member-defaultHtml

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/koalyptus/TableFilter/issues/788#issuecomment-682451566, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEM6XEHWKFOGITK6FWU7ODTSC6BDBANCNFSM4QLHPF7A.


This e-mail has been scanned for viruses Email Security.cloud - powered by Symantec. For further information visit https://www.symantec.com/products/messaging-security The information transmitted by this email is intended only for the person or entity to which it is addressed. This email may contain proprietary, confidential, and/or privileged material. If you are not the intended recipient of this message, be aware that any use, review, distribution, or reproduction is strictly prohibited. If you received this message in error, please contact the sender and delete the material from your system.