search

koalyptus / TableFilter

A Javascript library making HTML tables filterable and a bit more :)
https://www.tablefilter.com
MIT License
324 stars 95 forks source link

this.cfg vs this.config #822

Open netniV opened 2 years ago

netniV commented 2 years ago

Describe the bug Looking at the code, without doing an indepth review and breakdown test, there seems to be mixed using between this.cfg and this.config, the coding style should be consistent to prevent issues. For example, I'm pretty sure this is why the style_path and stylesheet overrides I tried to use failed to work and my browser was constantly trying to use the default path for the stylesheet.

koalyptus commented 2 years ago

Hi @netniV,

Don't hesitate to submit a PR following the guidelines. I agree the usage of this.config in the tablefilter.js seems incorrect, the intention was probably to use this.config().

Cheers