search

koaning / bulk

A Simple Bulk Labelling Tool
MIT License
550 stars 46 forks source link

Preserve all columns when saving csvs. #44

Closed jefromyers closed 1 year ago

jefromyers commented 1 year ago

I added a command line flag save-all-columns to override the default behavior of saving just the text column or path column. This enables the the ability to save all the column data. I personally like the default, but once I establish clusters of interest I often want all the data.

I just needed something quickly but considering it a little further there was discussion in issue #19 of moving towards a config. I wasn't sure if maybe this option would be better added to the UI? @koaning mentioned that he is interested in refactoring some of the code to be more modular and if we pull it to the UI might at least make refactoring simpler?

I wasn't exactly sure sure of the PR process. Looks like you use Black, so I did, and all tests pass.

koaning commented 1 year ago

As mentioned in https://github.com/koaning/bulk/issues/19, I think it'd be better to just return all the columns as base behavior. So I would prefer not to add a flag and to just make the same behavior the default.

jefromyers commented 1 year ago

You got it. I just made the changes so that's the default behavior.