search

koaning / calmcode-feedback

A repo to collect issues with calmcode.io
12 stars 0 forks source link

Seems like most links are overwriting current tab content #139

Closed mco-gh closed 6 months ago

mco-gh commented 2 years ago

Perhaps this is by design but I find that I'm often reading some of your text, or partway through a mini-course, when you share a link to a related resource. I think, "hmm...let's see what's there and maybe save it for future reference" but then poof - there goes my current thread.

Using "target="_blank" on the elements would ensure your links open in a new tab. If you agree, I'd be happy to submit a PR.

koaning commented 2 years ago

That's valid. URLs in the appendix often aren't related to site navigation so those may be better to open in a new tab.

I'll need to investigate if this holds true in general, but if so I should be able to update the jinja templates.

koaning commented 2 years ago

At the moment, I don't host the tutorials out in the open. Your PR attitude is certainly appreciated though. 🙂

koaning commented 6 months ago

The new site should fix this. Might come live tonight!