koaning / calmcode-feedback

A repo to collect issues with calmcode.io
12 stars 0 forks source link

Polars vs Pandas benchmark uses slow Pandas methods #188

Closed dshemetov closed 1 year ago

dshemetov commented 1 year ago

I think the Polars vs Pandas benchmark could use a different example. My feedback is in a comment on the notebook gist here. I'm less interested in a Polars vs Pandas debate (I think these benchmarks are pretty clear), I just want to educate people for best practices in both.

koaning commented 1 year ago

Ahhh good call.

This certainly seems like a fair comment, one that is making me consider adding another video "episode" to the series. Pandas has been getting some tough love recently, and this certainly seems like an observation worth sharing.

I do want to take the time to run this myself though. Something is making me wonder if the pandas 2.0 upgrade might improve things further.

koaning commented 1 year ago

I checked your code and left some feedback on the notebook.