search

koaning / calmcode-feedback

A repo to collect issues with calmcode.io
16 stars 0 forks source link

Add warning about pandas version #218

Open quoidautre opened 3 months ago

quoidautre commented 3 months ago

Don't forget to add a link (or a screenshot) of what needs a-fixin. Hello,

The url for bigmac.csv (https://calmcode.io/course/datasette/introduction) is broken : https://calmcode.io/datasets/bigmac.csv

Thanks.

koaning commented 3 months ago

I just pushed a PR that should fix this, thanks for reporting!

quoidautre commented 3 months ago

Hi, Perfect :)

quoidautre commented 3 months ago

But, there's an another error. Seems the problem is pandas : 

pandas==2.2.2
csvs-to-sqlite==1.3

$ csvs-to-sqlite bigmac.csv bigmac.db
Could not load bigmac.csv: read_csv() got an unexpected keyword argument 'error_bad_lines'
Loaded 0 dataframes
Added 1 CSV file to bigmac.db
koaning commented 3 months ago

Ah yeah, I had actually talked to Simon about that. The text needs to reflect the versions to get instead. Re opening this issue with another name now.

koaning commented 3 months ago

For now: pandas v1 should fix this.