search

koaning / embetter

just a bunch of useful embeddings
https://koaning.github.io/embetter/
MIT License
465 stars 15 forks source link

add a comma in __all__ section of `/home/runner/work/embetter/embetter/embetter/text/__init__.py` #101

Closed anopsy closed 6 months ago

anopsy commented 6 months ago

also I would like to know how to prevent this from happenig in the future, I've run the tests, but they clearly don't cover that, also the checks don't happen during a commit (As in scikit-learn) so I could definitely use some hint on how to check if there's no bug in the code I commit

koaning commented 6 months ago

I would need a slightly more elaborate issue to understand what is happening.

Why do you need to add a comma to the file? Could you elaborate on what is currently wrong with the file?

anopsy commented 6 months ago

Screenshot_20240422_130559_Chrome Sure. I noticed that when you accepted my PR it actually failed due to a check from Black. if that makes any sense. It looks like it's because of the missing comma after MatryoshkaEncoder.

koaning commented 6 months ago

Ahh, I must've merged it in a hurry without waiting for the CI to run. That's on me. Feel free to whip up a new PR with a fix if you like but I can also fix it later.

Thanks for the ping either way. :)

anopsy commented 6 months ago

I'll do that