Closed anopsy closed 7 months ago
I would need a slightly more elaborate issue to understand what is happening.
Why do you need to add a comma to the file? Could you elaborate on what is currently wrong with the file?
Sure. I noticed that when you accepted my PR it actually failed due to a check from Black. if that makes any sense. It looks like it's because of the missing comma after MatryoshkaEncoder.
Ahh, I must've merged it in a hurry without waiting for the CI to run. That's on me. Feel free to whip up a new PR with a fix if you like but I can also fix it later.
Thanks for the ping either way. :)
I'll do that
also I would like to know how to prevent this from happenig in the future, I've run the tests, but they clearly don't cover that, also the checks don't happen during a commit (As in scikit-learn) so I could definitely use some hint on how to check if there's no bug in the code I commit