comma added in embetter/text/__init_.py fixes #101

[anopsy]

fixed the comma btw I was curious about the ruff pre-commit hooks. You have that in sklego, I wondered why not here. I mean if there is a reason or just not yet. If not yet, then that might be something I would like to try to do.

[koaning]

Francesco added ruff on sklego. Given that I have a busy busy busy life I prefer not to make changes to my repos unless I really need to. Flake8 works fine, ruff is just a bit faster.

Thanks for the PR!

[anopsy]

Oh I see. Btw, do I see correctly that the unit tests failed on this PR? =========================== short test summary info ============================ FAILED tests/test_text.py::test_basic_bpemb[both] - UnicodeDecodeError: 'utf-8' codec can't decode byte 0xbf in position 40762: invalid start byte

I run the tests in pytests and all passed, before committing. Also checked the files locally with Black. I wonder what happened here?

[koaning]

The checks look green on your PR, no?

[anopsy]

I could have screenshoted it, I saw red on unittest, but now it's green. Now I wonder even more. 😅 Anyway, I'm happy it's all good now😊

[anopsy]

Francesco added ruff on sklego. Given that I have a busy busy busy life I prefer not to make changes to my repos unless I really need to. Flake8 works fine, ruff is just a bit faster.

Just to clarify, I meant the lack of pre-commits in general. I can't see neither ruff nor Flake8 as the pre-commit hooks. When I was committing:

• I didn't see any checks from flake8 happening (unless it's happening under the hood) ,
• Flake8 didn't catch that missing comma,
• I also don't see the pre-commit-config.yaml in the repo. I see there's .flake8 file, but I'm not sure at what point he checks the code.

[koaning]

Ah like that! I think the main reason why these are missing is because the embetter repo really only has one author (me) and I've sofar managed fine by running most of these things locally. Locally I usually do that by running make check which runs all of my checks.

You'd certainly be welcome to add these to the repo if you'd enjoy the exercise by the way, it's just that this is one of the plugins that I made in a hurry and never really took the effort to make the project more appropriate for a "multi-author" situation. Scikit-lego was multi-author from the start so we took more time into the developer experience there.

[anopsy]

yeah I noticed that you're the only contributor and thought that probably embetter was a just a little convenient tool. Anyway I would love to add the hooks. Thank you clarifying

[anopsy]

what do we want? flake8, black or ruff?

[koaning]

ruff should be fine!

- Vincent

On Wed 1. May 2024 at 16:58, Magdalena Anopsy @.***> wrote:

what do we want? flake8, black or ruff?

— Reply to this email directly, view it on GitHub https://github.com/koaning/embetter/pull/103#issuecomment-2088589371, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHY7D3LRSACVAWFQCYO2YLZAD7JPAVCNFSM6AAAAABG3ED4FKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBYGU4DSMZXGE . You are receiving this because you modified the open/close state.Message ID: @.***>