pre-commit hooks with ruff added

koaning / embetter

just a bunch of useful embeddings

https://koaning.github.io/embetter/

MIT License

469 stars 15 forks source link

pre-commit hooks with ruff added #104

Closed anopsy closed 7 months ago

anopsy commented 7 months ago

I was wondering if I should add embetter and tests in args: [--fix], similar to what's happening in sklego. I also let the ruff go over the jupyter notebooks, even though I saw it wasn't specified in the sklego pre-commit looks.

koaning commented 7 months ago

LGTM. Thanks!

koaning commented 7 months ago

I am aware that the code checks are error-ing btw, but it feels fine to merge since those errors feel unrelated.

anopsy commented 7 months ago

That's btw the same error I encountered previously, FAILED tests/test_text.py::test_basic_bpemb[max] , but the first time it disappeared after a while.