search

koaning / embetter

just a bunch of useful embeddings
https://koaning.github.io/embetter/
MIT License
465 stars 15 forks source link

`SentenceEncoder.device` attribute fix + tests. #34

Closed CarloLepelaars closed 1 year ago

CarloLepelaars commented 1 year ago

Fixes #33 .

  1. device in SentenceEncoder is now defined as attribute so it doesn't break in scikit-learn use cases.
  2. Tests for SentenceEncoder.
koaning commented 1 year ago

I think you forgot to add a docstring to your test, interrogate checks for that in CI.

koaning commented 1 year ago

PR looks good tho, will merge once CI passes.