search

koaning / scikit-lego

Extra blocks for scikit-learn pipelines.
https://koaning.github.io/scikit-lego/
MIT License
1.29k stars 118 forks source link

[FEATURE] Add parameter to allow NaNs in IdentityTransformer #524

Closed glevv closed 2 years ago

glevv commented 2 years ago

Make parameter force_all_finite in check_array function available to end user.

koaning commented 2 years ago

I'm open to a PR for this, but I'm wondering if we need to check for anything here at all for this component. The check_array function checks for many things and I think it might be better to add a single flag for either all the checks or none.

glevv commented 2 years ago

So something like check_input bool parameter? And set True as default for several releases for backwards compatibility?